Issue 7381049: Build fix for qt-wk2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7381049: Build fix for qt-wk2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by Zhenyao Mo

Modified:
11 years, 2 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Build fix for qt-wk2 Committed: https://code.google.com/p/angleproject/source/detail?r=1833

Patch Set 3 : #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/common/version.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/compiler/OutputHLSL.cpp	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Zhenyao Mo

I have no idea why this one affects qt mac build, but here is the ...

11 years, 2 months ago (2013-02-22 00:24:11 UTC) #1

kbr1

LGTM with one comment. https://codereview.appspot.com/7381049/diff/2001/src/compiler/OutputHLSL.cpp File src/compiler/OutputHLSL.cpp (right): https://codereview.appspot.com/7381049/diff/2001/src/compiler/OutputHLSL.cpp#newcode13 src/compiler/OutputHLSL.cpp:13: #include "compiler/UnfoldShortCircuit.h" common comes before ...

11 years, 2 months ago (2013-02-22 00:25:30 UTC) #2

kbr1

Also, not sure if you want to update the build version in this patch or ...

11 years, 2 months ago (2013-02-22 00:26:07 UTC) #3

Zhenyao Mo

On 2013/02/22 00:26:07, kbr1 wrote: > Also, not sure if you want to update the ...

11 years, 2 months ago (2013-02-22 00:28:27 UTC) #4

LGTM again

Expand All Messages | Collapse All Messages