Issue 7380044: Add support for vertex data rendered from CPU arrays.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7380044: Add support for vertex data rendered from CPU arrays. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bsalomon

Modified:
11 years, 9 months ago

Reviewers:
JimVV, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add support for vertex data rendered from CPU arrays. Committed: https://code.google.com/p/skia/source/detail?r=7807

Patch Set 4 : #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -66 lines)			Patch
M	src/gpu/GrBufferAllocPool.cpp	View	1	1 chunk	+15 lines, -3 lines	0 comments	Download
M	src/gpu/GrGeometryBuffer.h	View		3 chunks	+16 lines, -4 lines	0 comments	Download
M	src/gpu/GrIndexBuffer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/GrVertexBuffer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLBufferImpl.h	View	1 2 3	3 chunks	+5 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLBufferImpl.cpp	View		5 chunks	+45 lines, -15 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		3 chunks	+49 lines, -36 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

This contains the necessary code to have CPU array vertices without enabling them. It fixes ...

11 years, 9 months ago (2013-02-20 20:12:10 UTC) #1

robertphillips

LGTM + questions. Also - how much faster is this? https://codereview.appspot.com/7380044/diff/3001/src/gpu/gl/GrGLBufferImpl.h File src/gpu/gl/GrGLBufferImpl.h (right): https://codereview.appspot.com/7380044/diff/3001/src/gpu/gl/GrGLBufferImpl.h#newcode23 ...

11 years, 9 months ago (2013-02-20 20:36:37 UTC) #2

bsalomon

11 years, 9 months ago (2013-02-20 20:55:34 UTC) #3

It's between 40 and 50% reduction in frame time for SampleChart on the N10.

https://codereview.appspot.com/7380044/diff/3001/src/gpu/gl/GrGLBufferImpl.h
File src/gpu/gl/GrGLBufferImpl.h (right):

https://codereview.appspot.com/7380044/diff/3001/src/gpu/gl/GrGLBufferImpl.h#...
src/gpu/gl/GrGLBufferImpl.h:23: bool        fIsWrapped;
On 2013/02/20 20:36:37, robertphillips wrote:
> transpose 'and' and 'backed'?

Done.

https://codereview.appspot.com/7380044/diff/3001/src/gpu/gl/GrGLBufferImpl.h#...
src/gpu/gl/GrGLBufferImpl.h:38: GrGLuint bufferID() const { return fDesc.fID; }
On 2013/02/20 20:36:37, robertphillips wrote:
> This worries me a bit - is there another way?

This did return a void* until you asked me to make it a size_t :) But we will
need casts somewhere...glVertexAttribPointer takes a GLvoid*. However, it is
usually actually an offset... unless buffer 0 is bound , then it is a pointer.

Expand All Messages | Collapse All Messages