Issue 7378065: Fixed the hash key comparison function.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7378065: Fixed the hash key comparison function. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by sugoi

Modified:
11 years, 9 months ago

Reviewers:
bsalomon, junov1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Fixed the hash key comparison function. Committed: https://code.google.com/p/skia/source/detail?r=7853

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/gpu/GrResourceCache.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

On 2013/02/25 16:46:29, sugoi wrote: D'oh!! Nice find. LGTM.

11 years, 9 months ago (2013-02-25 16:47:19 UTC) #2

junov1

11 years, 9 months ago (2013-02-25 19:38:04 UTC) #3

On 2013/02/25 16:47:19, bsalomon wrote:
> On 2013/02/25 16:46:29, sugoi wrote:
> 
> D'oh!! Nice find. LGTM.

I get why this was not causing any tests to fail: if hashes are identical, we
move on to a full object compare as a safeguard against hash collisions.
I bet this fix will result in a measurable performance improvement due to all
the unnecessary memcmp.

Thinking out loud: When we add optimization strategies (like hashes), it would
be a good idea to also add unit tests that verify that the optimizations
actually kick-in for the cases where we expect it to.

Expand All Messages | Collapse All Messages