Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 7378051: Remove an empty file ossource_nspr.cpp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Zhenyao Mo
Modified:
12 years, 6 months ago
Reviewers:
apatrick, apatrick1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix ANGLE patching/building issues. 1) Remove an empty file: this causes patch apply failures when updating WebKit side ANGLE. 2) Fix a 64-to-32 conversion issue. 3) Append a change to Tokenizer.l that's left out in a previous CL. (cpp is already updated). Committed: https://code.google.com/p/angleproject/source/detail?r=1832

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/common/version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/osinclude.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/preprocessor/Tokenizer.l View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2
Zhenyao Mo
The deleted file src/compiler/ossource_nspr.cpp does not show in the uploaded patch. I think it's because ...
12 years, 6 months ago (2013-02-21 23:25:37 UTC) #1
apatrick1
12 years, 6 months ago (2013-02-21 23:48:40 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b