Issue 7377049: Small adjustments to SkRectShaderImageFilter to follow up on original cl.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7377049: Small adjustments to SkRectShaderImageFilter to follow up on original cl. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by sugoi

Modified:
11 years, 3 months ago

Reviewers:
bsalomon, senorblanco, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Small adjustments to SkRectShaderImageFilter to follow up on original cl. Committed: https://code.google.com/p/skia/source/detail?r=7816

Patch Set 2 : #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -17 lines)			Patch
M	include/core/SkImageFilter.h	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	include/effects/SkRectShaderImageFilter.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/effects/SkRectShaderImageFilter.cpp	View	1	2 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

lgtm w/ comment about saferef https://codereview.appspot.com/7377049/diff/1/src/effects/SkRectShaderImageFilter.cpp File src/effects/SkRectShaderImageFilter.cpp (right): https://codereview.appspot.com/7377049/diff/1/src/effects/SkRectShaderImageFilter.cpp#newcode24 src/effects/SkRectShaderImageFilter.cpp:24: SkASSERT(s); Lets say ref() ...

11 years, 3 months ago (2013-02-21 19:55:13 UTC) #2

I uploaded the change just to be sure.

Expand All Messages | Collapse All Messages