https://codereview.appspot.com/7374054/diff/2001/apiclient/discovery.py File apiclient/discovery.py (right): https://codereview.appspot.com/7374054/diff/2001/apiclient/discovery.py#newcode480 apiclient/discovery.py:480: class ResourceMethodParameters(object): It's too ambiguous as a standalone name. ...
11 years, 6 months ago
(2013-02-28 17:25:09 UTC)
#4
11 years, 6 months ago
(2013-02-28 17:28:06 UTC)
#5
LGTM
On 2013/02/28 17:25:09, dhermes wrote:
> https://codereview.appspot.com/7374054/diff/2001/apiclient/discovery.py
> File apiclient/discovery.py (right):
>
>
https://codereview.appspot.com/7374054/diff/2001/apiclient/discovery.py#newco...
> apiclient/discovery.py:480: class ResourceMethodParameters(object):
> It's too ambiguous as a standalone name. I'd like al the classes that will
> service the "Resource" class to begin with Resource.
>
> Also, in two changes, this will be transformed into "ResourceMethod" or some
> such thing, so the name is really very temporary.
>
> On 2013/02/28 17:23:25, jcgregorio_google wrote:
> > Why not MethodParameters?
Issue 7374054: Moving parameter data and data parsing into single object.
(Closed)
Created 11 years, 6 months ago by dhermes
Modified 11 years, 6 months ago
Reviewers: jcgregorio_google
Base URL:
Comments: 2