Issue 7374054: Moving parameter data and data parsing into single object.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7374054: Moving parameter data and data parsing into single object. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by dhermes

Modified:
12 years, 4 months ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

More Reviews

Description

Moving parameter data and data parsing into single object.

Patch Set 2 : Adding few tests and changing path params from map to set. #

Total comments: 2

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -52 lines)			Patch
	M	apiclient/discovery.py	View	1	7 chunks	+106 lines, -50 lines	2 comments	Download
	M	tests/test_discovery.py	View	1	3 chunks	+43 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dhermes

Adding few tests and changing path params from map to set.

12 years, 4 months ago (2013-02-27 23:27:23 UTC) #2

jcgregorio_google

https://codereview.appspot.com/7374054/diff/2001/apiclient/discovery.py File apiclient/discovery.py (right): https://codereview.appspot.com/7374054/diff/2001/apiclient/discovery.py#newcode480 apiclient/discovery.py:480: class ResourceMethodParameters(object): Why not MethodParameters?

12 years, 4 months ago (2013-02-28 17:23:25 UTC) #3

dhermes

12 years, 4 months ago (2013-02-28 17:25:09 UTC) #4

jcgregorio_google

12 years, 4 months ago (2013-02-28 17:28:06 UTC) #5

LGTM

On 2013/02/28 17:25:09, dhermes wrote:
> https://codereview.appspot.com/7374054/diff/2001/apiclient/discovery.py
> File apiclient/discovery.py (right):
> 
>
https://codereview.appspot.com/7374054/diff/2001/apiclient/discovery.py#newco...
> apiclient/discovery.py:480: class ResourceMethodParameters(object):
> It's too ambiguous as a standalone name. I'd like al the classes that will
> service the "Resource" class to begin with Resource.
> 
> Also, in two changes, this will be transformed into "ResourceMethod" or some
> such thing, so the name is really very temporary.
> 
> On 2013/02/28 17:23:25, jcgregorio_google wrote:
> > Why not MethodParameters?

Expand All Messages | Collapse All Messages