Issue 7372053: Replace A8 with RGBA8 when renderable A8 isn't supported

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7372053: Replace A8 with RGBA8 when renderable A8 isn't supported (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by robertphillips

Modified:
11 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Replace A8 with RGBA8 when renderable A8 isn't supported

Patch Set 3 : Added fix for NexusS and GalaxyNexus #

Total comments: 2

Patch Set 5 : Updated in preparation to reland #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -9 lines)			Patch
M	src/gpu/GrClipMaskManager.cpp	View	1 2 3 4	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2 3 4	3 chunks	+13 lines, -2 lines	0 comments	Download
M	src/gpu/effects/GrTextureDomainEffect.cpp	View	1 2 3 4	1 chunk	+27 lines, -6 lines	0 comments	Download
M	src/gpu/gl/GrGLShaderBuilder.h	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

bsalomon

On 2013/02/27 13:52:57, robertphillips wrote: Woah, I had forgotten that we had that helper function. ...

11 years, 4 months ago (2013-02-27 16:37:30 UTC) #2

bsalomon

lgtm w/ comment request. https://codereview.appspot.com/7372053/diff/10001/src/gpu/effects/GrTextureDomainEffect.cpp File src/gpu/effects/GrTextureDomainEffect.cpp (right): https://codereview.appspot.com/7372053/diff/10001/src/gpu/effects/GrTextureDomainEffect.cpp#newcode74 src/gpu/effects/GrTextureDomainEffect.cpp:74: if (kImagination_GrGLVendor == builder->ctxInfo().vendor()) { ...

11 years, 4 months ago (2013-02-28 21:14:06 UTC) #5

robertphillips

committed as r7914 https://codereview.appspot.com/7372053/diff/10001/src/gpu/effects/GrTextureDomainEffect.cpp File src/gpu/effects/GrTextureDomainEffect.cpp (right): https://codereview.appspot.com/7372053/diff/10001/src/gpu/effects/GrTextureDomainEffect.cpp#newcode74 src/gpu/effects/GrTextureDomainEffect.cpp:74: if (kImagination_GrGLVendor == builder->ctxInfo().vendor()) { On ...

11 years, 4 months ago (2013-03-01 14:11:16 UTC) #6

Message was sent while issue was closed.

committed as r7940

Expand All Messages | Collapse All Messages