Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4184)

Issue 7370052: Fixed doParse functions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by sugoi
Modified:
11 years, 8 months ago
Reviewers:
Humper, bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixed doParse functions For some reason, "success" wasn't set in a bunch of template specializations, causing it to be invalid when used later on. Committed: https://code.google.com/p/skia/source/detail?r=7969

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/utils/SkRTConf.cpp View 2 chunks +13 lines, -1 line 2 comments Download

Messages

Total messages: 5
sugoi
11 years, 8 months ago (2013-02-26 20:56:12 UTC) #1
sugoi
https://codereview.appspot.com/7370052/diff/1/src/utils/SkRTConf.cpp File src/utils/SkRTConf.cpp (right): https://codereview.appspot.com/7370052/diff/1/src/utils/SkRTConf.cpp#newcode148 src/utils/SkRTConf.cpp:148: template <typename T> T doParse(const char *, bool *success ...
11 years, 8 months ago (2013-02-26 20:56:52 UTC) #2
sugoi
https://codereview.appspot.com/7370052/diff/1/src/utils/SkRTConf.cpp File src/utils/SkRTConf.cpp (right): https://codereview.appspot.com/7370052/diff/1/src/utils/SkRTConf.cpp#newcode250 src/utils/SkRTConf.cpp:250: if (success) { This is the line where success ...
11 years, 8 months ago (2013-03-04 16:46:24 UTC) #3
Humper
lgtm, thanks On 2013/03/04 16:46:24, sugoi wrote: > https://codereview.appspot.com/7370052/diff/1/src/utils/SkRTConf.cpp > File src/utils/SkRTConf.cpp (right): > > ...
11 years, 8 months ago (2013-03-04 20:58:53 UTC) #4
sugoi
11 years, 8 months ago (2013-03-04 21:03:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r7969 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b