Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(962)

Issue 7370047: Use size_t for rowBytes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by Leon
Modified:
11 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Use size_t for rowBytes. Previously, we were using uint32_t sometimes, int sometimes, and size_t sometimes. Switch to using size_t, since we are actually talking about a number of bytes. In copyPixelsTo, use 0 as a flag to use the internal rowBytes, which is more consistent with setConfig. Committed: https://code.google.com/p/skia/source/detail?r=7843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M include/core/SkBitmap.h View 6 chunks +10 lines, -11 lines 0 comments Download
M src/core/SkBitmap.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Leon
11 years, 9 months ago (2013-02-22 23:34:50 UTC) #1
reed1
11 years, 9 months ago (2013-02-25 13:42:26 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b