Issue 7368051: Add chart bench.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7368051: Add chart bench. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by bsalomon

Modified:
11 years, 2 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add chart bench. Committed: https://code.google.com/p/skia/source/detail?r=7821

Patch Set 3 : #

Total comments: 3

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+203 lines, -0 lines)			Patch
	A	bench/ChartBench.cpp	View		1 chunk	+202 lines, -0 lines	3 comments	Download
	M	gyp/bench.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

lgtm + some questions https://codereview.appspot.com/7368051/diff/3001/bench/ChartBench.cpp File bench/ChartBench.cpp (right): https://codereview.appspot.com/7368051/diff/3001/bench/ChartBench.cpp#newcode94 bench/ChartBench.cpp:94: ChartBench(void* param, bool aa) : ...

11 years, 2 months ago (2013-02-22 15:07:45 UTC) #2

bsalomon

11 years, 2 months ago (2013-02-22 15:09:19 UTC) #3

https://codereview.appspot.com/7368051/diff/3001/bench/ChartBench.cpp
File bench/ChartBench.cpp (right):

https://codereview.appspot.com/7368051/diff/3001/bench/ChartBench.cpp#newcode99
bench/ChartBench.cpp:99: virtual const char* onGetName() SK_OVERRIDE {
On 2013/02/22 15:07:45, robertphillips wrote:
> Why is fShift initialized here and not in the ctor?

Ha... I just pasted in the wrong place. Will fix.

Expand All Messages | Collapse All Messages