Issue 7365047: Use CPU arrays for dynamic indices/vertices on ARM GPUs.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7365047: Use CPU arrays for dynamic indices/vertices on ARM GPUs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by bsalomon

Modified:
11 years, 10 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Use CPU arrays for dynamic indices/vertices on ARM GPUs. Committed: https://code.google.com/p/skia/source/detail?r=7810

Patch Set 1 #

Total comments: 4

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
M	include/gpu/gl/GrGLConfig.h	View	2 chunks	+8 lines, -0 lines	2 comments	Download
M	include/gpu/gl/GrGLConfig_chrome.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLUtil.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLUtil.cpp	View	1 chunk	+3 lines, -0 lines	2 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

lgtm + nits https://codereview.appspot.com/7365047/diff/1/include/gpu/gl/GrGLConfig.h File include/gpu/gl/GrGLConfig.h (right): https://codereview.appspot.com/7365047/diff/1/include/gpu/gl/GrGLConfig.h#newcode101 include/gpu/gl/GrGLConfig.h:101: * from VBOs. Chromium's command buffer ...

11 years, 10 months ago (2013-02-21 15:57:34 UTC) #2

bsalomon

11 years, 10 months ago (2013-02-21 16:34:39 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/7365047/diff/1/include/gpu/gl/GrGLConfig.h
File include/gpu/gl/GrGLConfig.h (right):

https://codereview.appspot.com/7365047/diff/1/include/gpu/gl/GrGLConfig.h#new...
include/gpu/gl/GrGLConfig.h:101: * from VBOs. Chromium's command buffer doesn't
allow glVertexAttrib with
On 2013/02/21 15:57:34, robertphillips wrote:
> ARRAY

Done.

https://codereview.appspot.com/7365047/diff/1/src/gpu/gl/GrGLUtil.cpp
File src/gpu/gl/GrGLUtil.cpp (right):

https://codereview.appspot.com/7365047/diff/1/src/gpu/gl/GrGLUtil.cpp#newcode173
src/gpu/gl/GrGLUtil.cpp:173: }
On 2013/02/21 15:57:34, robertphillips wrote:
> a comment at a location of your choosing?

Done.

Expand All Messages | Collapse All Messages