src/pkg/exp/ssa/promote.go - Issue 7364051: code review 7364051: exp/ssa: resolve botched merge.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/exp/ssa/promote.go

Issue 7364051: code review 7364051: exp/ssa: resolve botched merge. (Closed)

Patch Set: diff -r 37d391191e3f https://code.google.com/p/go/ Created 12 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/exp/ssa/promote.go

===================================================================

--- a/src/pkg/exp/ssa/promote.go

+++ b/src/pkg/exp/ssa/promote.go

@@ -8,7 +8,6 @@

import (

"fmt"

"go/types"

- "os"

)

// anonFieldPath is a linked list of anonymous fields entered by

@@ -121,7 +120,7 @@

func buildMethodSet(prog *Program, typ types.Type) MethodSet {

if prog.mode&LogSource != 0 {

- fmt.Fprintf(os.Stderr, "buildMethodSet %s %T\n", typ, typ)

+ defer logStack("buildMethodSet %s %T", typ, typ)()

}

// cands maps ids (field and method names) encountered at any

« no previous file with comments | « src/pkg/exp/ssa/builder.go ('k') | no next file » | no next file with comments »