Issue 7363061: state: Service.SetCharm endpoints check

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7363061: state: Service.SetCharm endpoints check (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by dimitern

Modified:
11 years, 2 months ago

Reviewers:
mp+150835

Visibility:
Public.

Description

state: Service.SetCharm endpoints check With this change, SetCharm will ensure the new charm that's about to be set is compatible with the current service's charm, i.e. implements all endpoints the service is currently in (extra relations are ok). Fixes LP bug #1032557 https://code.launchpad.net/~dimitern/juju-core/006-upgrade-charm-handle-relations/+merge/150835 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+150 lines, -6 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/conn_test.go	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	state/service.go	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	state/service_test.go	View	3 chunks	+115 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

11 years, 2 months ago (2013-02-27 17:03:32 UTC) #2

On 2013/02/27 16:13:42, dimitern wrote:
> Please take a look.

As discussed on the hangout, the following things need to happen in addition to
what's there already:
1) Only active relations have to be considered, not potential endpoints. This
has to be done carefully to make sure the relations snapshot we got from state
is most recent, checking the relation count is the same and making sure all
relation docs still exist by the time we set the charm.
2) New peer relations should be created in the same transaction (at the end).

So this is still WIP for now.

Expand All Messages | Collapse All Messages