Issue 7363055: Add initial frame BrowserView for charm browser.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7363055: Add initial frame BrowserView for charm browser.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by rharding

Modified:
12 years, 2 months ago

Reviewers:
mp+150420, j.c.sackett

Visibility:
Public.

Description

Add initial frame BrowserView for charm browser. - NOTE: this is not wired into anything. It's just new code to prepare/setup framing for the browser. - Add the overall module juju-browser, juju-browser-models - Start the process of the main BrowserView that will contain all UX for browsing. - Add first couple of tests that verify it renders/responds to an event. - Add the model for the Filter to track current view status. Test event hooks between view and Filter model. https://code.launchpad.net/~rharding/juju-gui/browserview/+merge/150420 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+231 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/modules-debug.js	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	app/templates/browser.handlebars	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	app/views/browser.js	View	1 chunk	+161 lines, -0 lines	0 comments	Download
M	test/index.html	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	test/test_browser.js	View	1 chunk	+58 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

j.c.sackett

12 years, 2 months ago (2013-02-27 13:52:41 UTC) #1

lgtm.

I have one question about the stuff in the top of your testfile, but it's not a
blocker. Feel free to answer in IRC.

https://codereview.appspot.com/7363055/diff/1/test/test_browser.js
File test/test_browser.js (right):

https://codereview.appspot.com/7363055/diff/1/test/test_browser.js#newcode3
test/test_browser.js:3: afterEach: false, it: false*/
What's this for?

Expand All Messages | Collapse All Messages