Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12)

Issue 735041: Treat Expires: <not RFC1123> as 0 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years ago by johnfargo
Modified:
15 years, 11 months ago
Reviewers:
zhoresh, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Per RFC2616, section 14.21: "HTTP/1.1 clients and caches MUST treat other invalid date formats, especially including the value "0", as in the past (i.e., "already expired")." So if you see a Date header but you can't parse it you should return 0 not -1 from getExpiresTime. Unless parseRfc1123Date always returns zero for dates it can't parse in which case you're already set. Thanks to Bryan McQuade for pointing this out.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -10 lines) Patch
java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java View 1 chunk +6 lines, -0 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/http/HttpResponseTest.java View 2 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 2
johnfargo
16 years ago (2010-03-24 21:07:38 UTC) #1
zhoresh
16 years ago (2010-03-24 21:34:56 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b