Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1842)

Issue 7350043: Add rounding to the separable blurs. This should ensure that the box blurs are energy-preserving (… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 8 months ago by Stephen White
Modified:
11 years, 8 months ago
Reviewers:
reed, Humper, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add rounding to the separable blurs. This should ensure that the box blurs are energy-preserving (ie., blurring solid 255 alpha stays 255 alpha). Disabled by default; will enable & rebaseline. Committed: https://code.google.com/p/skia/source/detail?r=7768

Patch Set 1 #

Patch Set 2 : Remove spurious backslashes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -10 lines) Patch
M src/effects/SkBlurMask.cpp View 1 12 chunks +104 lines, -10 lines 0 comments Download

Messages

Total messages: 3
Stephen White
PTAL. Greg, please let me know if this fixes the problems you're seeing.
11 years, 8 months ago (2013-02-15 19:27:30 UTC) #1
Humper
On 2013/02/15 19:27:30, Stephen White wrote: > PTAL. Greg, please let me know if this ...
11 years, 8 months ago (2013-02-19 14:32:53 UTC) #2
reed1
11 years, 8 months ago (2013-02-19 14:47:55 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b