Issue 7346055: Add GrGLBufferImpl to unify implementation of GrGLVertexBuffer and GrGLIndexBuffer.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7346055: Add GrGLBufferImpl to unify implementation of GrGLVertexBuffer and GrGLIndexBuffer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by bsalomon

Modified:
11 years, 9 months ago

Reviewers:
JimVV, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Add GrGLBufferImpl to unify implementation of GrGLVertexBuffer and GrGLIndexBuffer. Committed: https://code.google.com/p/skia/source/detail?r=7798

Patch Set 2 : #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+292 lines, -259 lines)			Patch
M	gyp/gpu.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A	src/gpu/gl/GrGLBufferImpl.h	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download
A	src/gpu/gl/GrGLBufferImpl.cpp	View		1 chunk	+131 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.h	View		3 chunks	+15 lines, -14 lines	0 comments	Download
M	src/gpu/gl/GrGLIndexBuffer.cpp	View		1 chunk	+18 lines, -94 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.h	View		3 chunks	+16 lines, -12 lines	0 comments	Download
M	src/gpu/gl/GrGLVertexBuffer.cpp	View		1 chunk	+19 lines, -106 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		2 chunks	+34 lines, -33 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Before I go messing with the implementation of these classes I thought it'd be good ...

11 years, 10 months ago (2013-02-19 22:39:16 UTC) #1

robertphillips

lgtm https://codereview.appspot.com/7346055/diff/1/src/gpu/gl/GrGLBufferImpl.cpp File src/gpu/gl/GrGLBufferImpl.cpp (right): https://codereview.appspot.com/7346055/diff/1/src/gpu/gl/GrGLBufferImpl.cpp#newcode68 src/gpu/gl/GrGLBufferImpl.cpp:68: GrAssert(NULL != fLockPtr);? https://codereview.appspot.com/7346055/diff/1/src/gpu/gl/GrGLBufferImpl.h File src/gpu/gl/GrGLBufferImpl.h (right): https://codereview.appspot.com/7346055/diff/1/src/gpu/gl/GrGLBufferImpl.h#newcode15 ...

11 years, 10 months ago (2013-02-19 23:12:52 UTC) #2

bsalomon

11 years, 9 months ago (2013-02-20 15:19:03 UTC) #3

https://codereview.appspot.com/7346055/diff/1/src/gpu/gl/GrGLBufferImpl.cpp
File src/gpu/gl/GrGLBufferImpl.cpp (right):

https://codereview.appspot.com/7346055/diff/1/src/gpu/gl/GrGLBufferImpl.cpp#n...
src/gpu/gl/GrGLBufferImpl.cpp:68: 
On 2013/02/19 23:12:52, robertphillips wrote:
> GrAssert(NULL != fLockPtr);?

the this->isLocked() assert should cover that.

https://codereview.appspot.com/7346055/diff/1/src/gpu/gl/GrGLBufferImpl.h
File src/gpu/gl/GrGLBufferImpl.h (right):

https://codereview.appspot.com/7346055/diff/1/src/gpu/gl/GrGLBufferImpl.h#new...
src/gpu/gl/GrGLBufferImpl.h:15: 
On 2013/02/19 23:12:52, robertphillips wrote:
> // comment on this class' purpose?
Done with:

/**
 * This class serves as the implementation of GrGL*Buffer classes. It was
written to avoid code
 * duplication in those classes.
 */

Expand All Messages | Collapse All Messages