Issue 73430043: Issue 1687: adminAccountManagementPage: Give more details in the alert shown when deleting an accou…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 73430043: Issue 1687: adminAccountManagementPage: Give more details in the alert shown when deleting an accou…

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by franklingujunchao

Modified:
10 years, 6 months ago

Reviewers:
arnold.koroa, damith

Visibility:
Public.

More Reviews

Description

Issue 1687: adminAccountManagementPage: Give more details in the alert shown when deleting an accou…

Patch Set 2 : Issue 1687: adminAccountManagementPage: Give more details in the alert shown #

Total comments: 1

Patch Set 3 : Issue 1687: adminAccountManagementPage: Give more details in the alert shown when deleting an accou… #

Total comments: 1

Patch Set 4 : Issue 1687: adminAccountManagementPage: Give more details in the alert shown when deleting an accou… #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	src/main/webapp/js/administrator.js	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	src/main/webapp/jsp/adminAccountManagement.jsp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

arnold.koroa

https://codereview.appspot.com/73430043/diff/1/src/main/webapp/js/administrator.js File src/main/webapp/js/administrator.js (right): https://codereview.appspot.com/73430043/diff/1/src/main/webapp/js/administrator.js#newcode121 src/main/webapp/js/administrator.js:121: console.log(google_id); debugging lines? If it is should remove. https://codereview.appspot.com/73430043/diff/1/src/main/webapp/js/administrator.js#newcode122 ...

10 years, 6 months ago (2014-03-10 08:51:51 UTC) #1

arnold.koroa

https://codereview.appspot.com/73430043/diff/20001/src/main/webapp/js/administrator.js File src/main/webapp/js/administrator.js (right): https://codereview.appspot.com/73430043/diff/20001/src/main/webapp/js/administrator.js#newcode121 src/main/webapp/js/administrator.js:121: return confirm("Are you sure you want to delete this ...

10 years, 6 months ago (2014-03-11 02:19:10 UTC) #2

damith

10 years, 6 months ago (2014-03-11 03:42:43 UTC) #3

https://codereview.appspot.com/73430043/diff/40001/src/main/webapp/js/adminis...
File src/main/webapp/js/administrator.js (right):

https://codereview.appspot.com/73430043/diff/40001/src/main/webapp/js/adminis...
src/main/webapp/js/administrator.js:120: function
toggleDeleteAccountConfirmation(google_id) {
We usually use camelCase for names. :-p

Expand All Messages | Collapse All Messages