Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(789)

Issue 7342047: Fix for skp chunk sizes when clips are used outside of any save (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by robertphillips
Modified:
11 years, 4 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix for skp chunk sizes when clips are used outside of any save

Patch Set 1 #

Patch Set 2 : Add inline comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/core/SkPictureRecord.cpp View 1 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
robertphillips
11 years, 4 months ago (2013-02-15 15:13:01 UTC) #1
reed1
1. perhaps add a brief comment inline for why we're checking for empty. 2. can ...
11 years, 4 months ago (2013-02-15 15:52:17 UTC) #2
robertphillips
1) done 2) the Pictures test actually already does this. This was a patch to ...
11 years, 4 months ago (2013-02-15 17:26:24 UTC) #3
robertphillips
11 years, 4 months ago (2013-03-01 14:18:23 UTC) #4
Message was sent while issue was closed.
committed as r7917
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b