Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(198)

Issue 7337043: Refactor charm/hook, worker/uniter/hook (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by dimitern
Modified:
12 years, 5 months ago
Reviewers:
mp+148500
Visibility:
Public.

Description

Refactor charm/hook, worker/uniter/hook As discussed, this splits worker/uniter/hook module into uniter-related stuff (Info and validation) and generic charm hook stuff (defined hooks kinds). Adds UnitHooks and RelationHooks slices, which contain their respective Kinds. Changed uniter code to match the code split. Added a Meta method Hooks() to return map[string]bool of all (possible) hooks according to the metadata. This is needed for a follow-up CL to fix bug #864164. https://code.launchpad.net/~dimitern/juju-core/reorganize-charm-hooks/+merge/148500 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -223 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
A charm/hook/hook.go View 1 chunk +64 lines, -0 lines 0 comments Download
M charm/meta.go View 2 chunks +30 lines, -0 lines 0 comments Download
M charm/meta_test.go View 1 chunk +30 lines, -0 lines 0 comments Download
worker/uniter/hook/hook.go View 1 chunk +0 lines, -78 lines 0 comments Download
D worker/uniter/hook/hook.go View 1 chunk +45 lines, -0 lines 0 comments Download
worker/uniter/hook/hook_test.go View 1 chunk +0 lines, -55 lines 0 comments Download
worker/uniter/hook/hook_test.go View 1 chunk +56 lines, -0 lines 0 comments Download
M worker/uniter/modes.go View 6 chunks +9 lines, -8 lines 0 comments Download
worker/uniter/relation/hookqueue.go View 10 chunks +13 lines, -12 lines 0 comments Download
worker/uniter/relation/hookqueue_test.go View 8 chunks +9 lines, -8 lines 0 comments Download
worker/uniter/relation/relation.go View 3 chunks +4 lines, -3 lines 0 comments Download
worker/uniter/relation/relation_test.go View 6 chunks +18 lines, -17 lines 0 comments Download
worker/uniter/relationer.go View 4 chunks +6 lines, -5 lines 0 comments Download
worker/uniter/relationer_test.go View 13 chunks +19 lines, -18 lines 0 comments Download
worker/uniter/state.go View 3 chunks +3 lines, -3 lines 0 comments Download
worker/uniter/state_test.go View 6 chunks +9 lines, -8 lines 0 comments Download
worker/uniter/uniter.go View 9 chunks +9 lines, -8 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b