Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 73360043: NewContainerManager Unknown Options

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by waigani
Modified:
11 years, 2 months ago
Reviewers:
thumper, mp+210114
Visibility:
Public.

Description

NewContainerManager Unknown Options Raise warnings for unknown options passed to NewContainerManager. https://code.launchpad.net/~waigani/juju-core/managers-should-warn-for-any-unknown-options/+merge/210114 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M container/kvm/kvm.go View 1 chunk +6 lines, -0 lines 0 comments Download
M container/kvm/kvm_test.go View 1 chunk +9 lines, -0 lines 0 comments Download
M container/lxc/lxc.go View 1 chunk +6 lines, -0 lines 0 comments Download
M container/lxc/lxc_test.go View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 2
waigani
Please take a look.
11 years, 2 months ago (2014-03-10 03:00:34 UTC) #1
thumper
11 years, 2 months ago (2014-03-10 03:42:50 UTC) #2
On 2014/03/10 03:00:34, waigani wrote:
> Please take a look.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b