Issue 73360043: NewContainerManager Unknown Options

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 73360043: NewContainerManager Unknown Options

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by waigani

Modified:
11 years, 3 months ago

Reviewers:
thumper, mp+210114

Visibility:
Public.

Description

NewContainerManager Unknown Options Raise warnings for unknown options passed to NewContainerManager. https://code.launchpad.net/~waigani/juju-core/managers-should-warn-for-any-unknown-options/+merge/210114 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -0 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	container/kvm/kvm.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	container/kvm/kvm_test.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	container/lxc/lxc.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	container/lxc/lxc_test.go	View	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

thumper

11 years, 3 months ago (2014-03-10 03:42:50 UTC) #2

On 2014/03/10 03:00:34, waigani wrote:
> Please take a look.

LGTM

Expand All Messages | Collapse All Messages