Issue 7330044: bench_graph_svg: generate output in consistently sorted order, to make diffs more useful

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7330044: bench_graph_svg: generate output in consistently sorted order, to make diffs more useful (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by epoger

Modified:
11 years, 8 months ago

Reviewers:
benchen

CC:
skia-review_googlegroups.com, skiabot_google.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

bench_graph_svg: generate output in consistently sorted order, to make diffs more useful TBR=benchen Committed: https://code.google.com/p/skia/source/detail?r=7744

Patch Set 1 #

Total comments: 2

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1070 lines, -1068 lines)			Patch
M	bench/bench_graph_svg.py	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	tools/tests/benchgraphs/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_32/output-expected/graph.xhtml	View	1 chunk	+1059 lines, -1059 lines	1 comment	Download
M	tools/tests/run.sh	View	1 chunk	+1 line, -7 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

epoger

... and re-enabled the self-test https://codereview.appspot.com/7330044/diff/1/tools/tests/benchgraphs/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_32/output-expected/graph.xhtml File tools/tests/benchgraphs/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_32/output-expected/graph.xhtml (right): https://codereview.appspot.com/7330044/diff/1/tools/tests/benchgraphs/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_32/output-expected/graph.xhtml#newcode96 tools/tests/benchgraphs/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_32/output-expected/graph.xhtml:96: <g id="desk_amazon.skp_tile_256x256_multi_2_threads__{'scalar': 'data_skp_device_bitmap_multi_4_mode_tile_256_256_timeIndividualTiles'}"> I ...

11 years, 10 months ago (2013-02-14 18:18:54 UTC) #1

epoger

P.S. Time to run the bench self-test did not change as a result of adding ...

11 years, 10 months ago (2013-02-14 18:21:06 UTC) #2

epoger

Committing TBR so I can get on to the next step and maybe speed things ...

11 years, 10 months ago (2013-02-14 18:54:12 UTC) #3

LGTM.

Expand All Messages | Collapse All Messages