Issue 73240044: Add back test for user rejected value

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 73240044: Add back test for user rejected value (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rafaelw

Modified:
11 years, 1 month ago

Reviewers:
arv, John Messerly

Base URL:
https://github.com/Polymer/NodeBind.git@master

Visibility:
Public.

More Reviews

Description

Add back test for user rejected value Not sure how this got lost. Asserts that https://github.com/Polymer/NodeBind/blob/master/src/NodeBind.js#L186 is required (otherwise the element wouldn't find out that the value was put back to its initial value, because from it's observable's POV the value would not have changed). R=arv BUG= Committed: https://github.com/Polymer/NodeBind/commit/45916fe

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -1 line)			Patch
	M	tests/tests.js	View		2 chunks	+27 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as r45916fe (presubmit successful).

11 years, 1 month ago (2014-03-09 16:26:35 UTC) #3

Message was sent while issue was closed.

LGTM

Expand All Messages | Collapse All Messages