Issue 7322078: debug dump functions for mathematica visualization

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7322078: debug dump functions for mathematica visualization (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by Humper

Modified:
11 years, 10 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

debug dump functions for mathematica visualization BUG= Committed: https://code.google.com/p/skia/source/detail?r=7743

Patch Set 1 #

Total comments: 1

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -0 lines)			Patch
	M	gyp/utils.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	A	include/utils/SkDebugUtils.h	View		1 chunk	+94 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Humper

This is just the mathematica dump functions (renamed as Brian suggested)

11 years, 10 months ago (2013-02-14 16:44:09 UTC) #1

bsalomon

lgtm w/ nit about using SkDEBUGFAIL https://codereview.appspot.com/7322078/diff/1/include/utils/SkDebugUtils.h File include/utils/SkDebugUtils.h (right): https://codereview.appspot.com/7322078/diff/1/include/utils/SkDebugUtils.h#newcode21 include/utils/SkDebugUtils.h:21: SkASSERT(!!!"Need to specialize ...

11 years, 10 months ago (2013-02-14 16:52:22 UTC) #2

Humper

11 years, 10 months ago (2013-02-14 18:56:05 UTC) #3

ok will fix and land

On 2013/02/14 16:52:22, bsalomon wrote:
> lgtm w/ nit about using SkDEBUGFAIL
> 
> https://codereview.appspot.com/7322078/diff/1/include/utils/SkDebugUtils.h
> File include/utils/SkDebugUtils.h (right):
> 
>
https://codereview.appspot.com/7322078/diff/1/include/utils/SkDebugUtils.h#ne...
> include/utils/SkDebugUtils.h:21: SkASSERT(!!!"Need to specialize
> SkDebugDumpMathematica for your type, sorry.");
> There's SkDebugFail

Expand All Messages | Collapse All Messages