Issue 7322064: Move view matrix flush to GrGLProgram.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7322064: Move view matrix flush to GrGLProgram. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by bsalomon

Modified:
13 years, 1 month ago

Reviewers:
Stephen White, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Move view matrix flush to GrGLPrograms. Committed: https://code.google.com/p/skia/source/detail?r=7713

Patch Set 2 : #

Total comments: 2

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+132 lines, -120 lines)			Patch
M	src/gpu/gl/GrGLProgram.h	View	1	6 chunks	+29 lines, -8 lines	2 comments	Download
M	src/gpu/gl/GrGLProgram.cpp	View	1	3 chunks	+48 lines, -11 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.h	View		2 chunks	+11 lines, -20 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View		3 chunks	+42 lines, -79 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

https://codereview.appspot.com/7322064/diff/2001/src/gpu/gl/GrGLProgram.h File src/gpu/gl/GrGLProgram.h (right): https://codereview.appspot.com/7322064/diff/2001/src/gpu/gl/GrGLProgram.h#newcode119 src/gpu/gl/GrGLProgram.h:119: fViewMatrix = SkMatrix::InvalidMatrix(); I think we should set fHeight ...

13 years, 1 month ago (2013-02-13 16:05:11 UTC) #3

bsalomon

13 years, 1 month ago (2013-02-13 16:06:16 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/7322064/diff/2001/src/gpu/gl/GrGLProgram.h
File src/gpu/gl/GrGLProgram.h (right):

https://codereview.appspot.com/7322064/diff/2001/src/gpu/gl/GrGLProgram.h#new...
src/gpu/gl/GrGLProgram.h:119: fViewMatrix = SkMatrix::InvalidMatrix();
On 2013/02/13 16:05:11, robertphillips wrote:
> I think we should set fHeight too since we are replacing the fRTHeight
variable

Nice catch, Rob. This may be responsible for the GM failures.

Expand All Messages | Collapse All Messages