Issue 7317048: bench_graph_svg self-test: add non-tile bench data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7317048: bench_graph_svg self-test: add non-tile bench data (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by epoger

Modified:
11 years, 4 months ago

Reviewers:
benchen

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

bench_graph_svg self-test: add non-tile bench data TBR=benchen Committed: https://code.google.com/p/skia/source/detail?r=7750

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+561 lines, -70 lines)			Patch
	M	tools/tests/benchgraphs/Skia_Shuttle_Ubuntu12_ATI5770_Float_Bench_32/output-expected/graph.xhtml	View		61 chunks	+546 lines, -65 lines	1 comment	Download
	M	tools/tests/run.sh	View		3 chunks	+15 lines, -5 lines	0 comments	Download

Total messages: 2

epoger

Adding this non-tile bench data will give us more confidence that any speedups we put ...

11 years, 4 months ago (2013-02-15 16:41:37 UTC) #1

benchen

11 years, 4 months ago (2013-02-15 16:47:22 UTC) #2

LGTM. Both the xhtml text diff and the addition of "record_rtree" in the browser
make sense.