One thing I've been pondering is can we use 3to2 and kill the Python 2.x ...
11 years, 6 months ago
(2013-02-20 01:17:08 UTC)
#4
One thing I've been pondering is can we use 3to2 and kill the Python
2.x version of the code?
On Tue, Feb 19, 2013 at 6:25 PM, <dhermes@google.com> wrote:
> Also, pylint complained about some of the Python3 syntax, so my changes
> there were done fully by hand.
>
> https://codereview.appspot.com/7314118/
--
Joe Gregorio http://bitworking.org
Not likely. None of the AppEngine specific parts are in the python3 package. Though we ...
11 years, 6 months ago
(2013-02-20 02:15:41 UTC)
#5
Not likely. None of the AppEngine specific parts are in the python3 package.
Though we could try to tear them out a a separate module in the python2
package.
On Tue, Feb 19, 2013 at 5:17 PM, Joe Gregorio <joe@bitworking.org> wrote:
> One thing I've been pondering is can we use 3to2 and kill the Python
> 2.x version of the code?
>
> On Tue, Feb 19, 2013 at 6:25 PM, <dhermes@google.com> wrote:
> > Also, pylint complained about some of the Python3 syntax, so my changes
> > there were done fully by hand.
> >
> > https://codereview.appspot.com/7314118/
>
>
>
> --
> Joe Gregorio http://bitworking.org
>
--
Danny Hermes
Developer Programs Engineer
On 2013/02/20 02:15:41, dhermes wrote: > Not likely. None of the AppEngine specific parts are ...
11 years, 6 months ago
(2013-02-20 20:16:05 UTC)
#6
On 2013/02/20 02:15:41, dhermes wrote:
> Not likely. None of the AppEngine specific parts are in the python3 package.
>
> Though we could try to tear them out a a separate module in the python2
> package.
SGTM, but let's do that as a separate CL.
>
>
> On Tue, Feb 19, 2013 at 5:17 PM, Joe Gregorio <mailto:joe@bitworking.org>
wrote:
>
> > One thing I've been pondering is can we use 3to2 and kill the Python
> > 2.x version of the code?
> >
> > On Tue, Feb 19, 2013 at 6:25 PM, <mailto:dhermes@google.com> wrote:
> > > Also, pylint complained about some of the Python3 syntax, so my changes
> > > there were done fully by hand.
> > >
> > > https://codereview.appspot.com/7314118/
> >
> >
> >
> > --
> > Joe Gregorio http://bitworking.org
> >
>
>
>
> --
> Danny Hermes
> Developer Programs Engineer
Just tried to apply the patch and it failed with: applying issue7314118_1.diff patching file python3/httplib2/iri2uri.py ...
11 years, 6 months ago
(2013-02-20 20:18:11 UTC)
#7
Just tried to apply the patch and it failed with:
applying issue7314118_1.diff
patching file python3/httplib2/iri2uri.py
Hunk #1 FAILED at 27
1 out of 1 hunks FAILED -- saving rejects to file
python3/httplib2/iri2uri.py.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh issue7314118_1.diff
jcgregorio@wpgntai-ubiq72:~/oldhome/projects/httplib2 on default?
[issue7314118_1.diff]
$
On 2013/02/20 20:16:05, jcgregorio wrote:
> On 2013/02/20 02:15:41, dhermes wrote:
> > Not likely. None of the AppEngine specific parts are in the python3 package.
> >
> > Though we could try to tear them out a a separate module in the python2
> > package.
>
> SGTM, but let's do that as a separate CL.
>
> >
> >
> > On Tue, Feb 19, 2013 at 5:17 PM, Joe Gregorio <mailto:joe@bitworking.org>
> wrote:
> >
> > > One thing I've been pondering is can we use 3to2 and kill the Python
> > > 2.x version of the code?
> > >
> > > On Tue, Feb 19, 2013 at 6:25 PM, <mailto:dhermes@google.com> wrote:
> > > > Also, pylint complained about some of the Python3 syntax, so my changes
> > > > there were done fully by hand.
> > > >
> > > > https://codereview.appspot.com/7314118/
> > >
> > >
> > >
> > > --
> > > Joe Gregorio http://bitworking.org
> > >
> >
> >
> >
> > --
> > Danny Hermes
> > Developer Programs Engineer
Issue 7314118: Making indents consistent with PEP8.
(Closed)
Created 11 years, 6 months ago by dhermes
Modified 11 years, 6 months ago
Reviewers: jcgregorio, joe_bitworking.org
Base URL:
Comments: 0