worker/firewaller/firewaller.go - Issue 7314116: state/api: use error codes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: worker/firewaller/firewaller.go

Issue 7314116: state/api: use error codes

Patch Set: state/api: use error codes Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: worker/firewaller/firewaller.go

=== modified file 'worker/firewaller/firewaller.go'

--- worker/firewaller/firewaller.go 2013-02-19 11:43:12 +0000

+++ worker/firewaller/firewaller.go 2013-02-20 17:13:17 +0000

@@ -316,10 +316,8 @@

machineId, err = unit.AssignedMachineId()

if state.IsNotFound(err) {

continue

- } else if err != nil {

- if _, ok := err.(*state.NotAssignedError); !ok {

- return err

- }

+ } else if err != nil && !state.IsNotAssigned(err) {

+ return err

}

if unitd, known := fw.unitds[name]; known {

« no previous file with comments | « state/unit.go ('k') | no next file » | no next file with comments »