Add support for using ANGLE in bench_pictures.

Add support for using ANGLE in bench_pictures.

BUG=https://code.google.com/p/skia/issues/detail?id=1012

Other cleanups:
Remove setDeviceType from PictureBenchmark, since it is unnecessary.
Dereference PictureRenderer::fGrContext when done with it.
Make PictureRenderer::fGrContext and PictureRenderer::fGrContextFactory private, since they are not used by subclasses.

Committed: https://code.google.com/p/skia/source/detail?r=7677

[bsalomon, 2013-02-08 19:03:55]

lgtm with one minor point inline.

https://codereview.appspot.com/7314063/diff/1/tools/PictureRenderer.h
File tools/PictureRenderer.h (right):

https://codereview.appspot.com/7314063/diff/1/tools/PictureRenderer.h#newcode134
tools/PictureRenderer.h:134: #endif
I don't know that initializing this to kNULL makes sense here. kNULL is not a
sentinel value but an actual type of SkGLContext... one that draws nothing. We
use it in regular bench to measure the CPU overhead of Ganesh (by making the GL
calls do nothing). While it might be a good idea to also add the null gpu config
to bench_pictures, I don't think that is the intent here.

[Leon, 2013-02-08 19:17:35]

https://codereview.appspot.com/7314063/diff/1/tools/PictureRenderer.h
File tools/PictureRenderer.h (right):

https://codereview.appspot.com/7314063/diff/1/tools/PictureRenderer.h#newcode134
tools/PictureRenderer.h:134: #endif
On 2013/02/08 19:03:55, bsalomon wrote:
> I don't know that initializing this to kNULL makes sense here. kNULL is not a
> sentinel value but an actual type of SkGLContext... one that draws nothing. We
> use it in regular bench to measure the CPU overhead of Ganesh (by making the
GL
> calls do nothing). While it might be a good idea to also add the null gpu
config
> to bench_pictures, I don't think that is the intent here.
> 

Done.

[bsalomon, 2013-02-08 19:24:04]

lgtm


On Fri, Feb 8, 2013 at 2:17 PM, <scroggo@google.com> wrote:

>
>
https://codereview.appspot.**com/7314063/diff/1/tools/**PictureRenderer.h<htt...
> File tools/PictureRenderer.h (right):
>
> https://codereview.appspot.**com/7314063/diff/1/tools/**
>
PictureRenderer.h#newcode134<https://codereview.appspot.com/7314063/diff/1/tools/PictureRenderer.h#newcode134>
> tools/PictureRenderer.h:134: #endif
> On 2013/02/08 19:03:55, bsalomon wrote:
>
>> I don't know that initializing this to kNULL makes sense here. kNULL
>>
> is not a
>
>> sentinel value but an actual type of SkGLContext... one that draws
>>
> nothing. We
>
>> use it in regular bench to measure the CPU overhead of Ganesh (by
>>
> making the GL
>
>> calls do nothing). While it might be a good idea to also add the null
>>
> gpu config
>
>> to bench_pictures, I don't think that is the intent here.
>>
>
>
> Done.
>
>
https://codereview.appspot.**com/7314063/<https://codereview.appspot.com/7314...
>