Issue 7313049: Fix errors when compiling with -Wall -Werror on Android.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7313049: Fix errors when compiling with -Wall -Werror on Android. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by DerekS

Modified:
11 years, 11 months ago

Reviewers:
EricB, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix errors when compiling with -Wall -Werror on Android. This CL also turns those features on by default on Android Committed: https://code.google.com/p/skia/source/detail?r=7645

Patch Set 1 #

Patch Set 2 : fix gyp error #

Patch Set 3 : add -fstrict-aliasing #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -141 lines)			Patch
M	bench/BlurRectBench.cpp	View		2 chunks	+10 lines, -11 lines	0 comments	Download
M	gyp/common_conditions.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gyp/jsoncpp.gyp	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	gyp/libjpeg.gyp	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gyp/utils.gyp	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
M	include/core/SkFloatingPoint.h	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	include/utils/SkRandom.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SamplePolyToPoly.cpp	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/core/SkAdvancedTypefaceMetrics.cpp	View		3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/core/SkPictureFlat.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	src/images/SkMovie_gif.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/opts/SkBitmapProcState_matrixProcs_neon.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/opts/SkBitmapProcState_matrix_clamp_neon.h	View		9 chunks	+7 lines, -16 lines	0 comments	Download
M	src/opts/SkBitmapProcState_matrix_repeat_neon.h	View		3 chunks	+1 line, -3 lines	0 comments	Download
M	src/opts/SkBlitRow_opts_arm_neon.cpp	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/ports/FontHostConfiguration_android.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ports/SkFontHost_android.cpp	View		4 chunks	+5 lines, -3 lines	0 comments	Download
D	src/utils/android/ashmem.c	View	1 2	1 chunk	+0 lines, -82 lines	0 comments	Download
A +	src/utils/android/ashmem.cpp	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	tests/PaintTest.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/ReadWriteAlphaTest.cpp	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

11 years, 11 months ago (2013-02-06 18:29:31 UTC) #2

seems fine, but all of the neon changes are scary, 'cause I dunno what is going
on in the first place.

Expand All Messages | Collapse All Messages