Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(121)

Issue 7312083: Fix filter optimizations to take the paint's alpha into account (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by robertphillips
Modified:
11 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This doesn't change anything in the skp library but, since the Apply functions don't handle the two alpha case, I thought it best to restrict the optimizations.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improved clarity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -8 lines) Patch
M tools/filtermain.cpp View 1 2 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 4
robertphillips
11 years, 7 months ago (2013-02-12 14:55:41 UTC) #1
reed1
lgtm, but w/ a suggestion to rewrite a little for more clarity/simplicity. Also, it would ...
11 years, 7 months ago (2013-02-12 15:05:03 UTC) #2
robertphillips
Added comments https://codereview.appspot.com/7312083/diff/1/tools/filtermain.cpp File tools/filtermain.cpp (right): https://codereview.appspot.com/7312083/diff/1/tools/filtermain.cpp#newcode60 tools/filtermain.cpp:60: Thanks - that is a lot clearer.
11 years, 7 months ago (2013-02-12 15:27:17 UTC) #3
robertphillips
11 years, 7 months ago (2013-02-13 13:27:58 UTC) #4
Message was sent while issue was closed.
committed as r7711
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b