Issue 7312061: Remove GR_DISABLE_DRAW_BUFFERING, replace with RTConf variable.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7312061: Remove GR_DISABLE_DRAW_BUFFERING, replace with RTConf variable. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bsalomon

Modified:
11 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove GR_DISABLE_DRAW_BUFFERING, replace with RTConf variable. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=7656

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -26 lines)			Patch
M	include/gpu/GrConfig.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	include/gpu/GrUserConfig.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	11 chunks	+15 lines, -12 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + documentation suggestions https://codereview.appspot.com/7312061/diff/1/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.appspot.com/7312061/diff/1/src/gpu/GrContext.cpp#newcode37 src/gpu/GrContext.cpp:37: // debugging simpler. maybe: "gpu.deferDrawing" ...

11 years, 7 months ago (2013-02-07 20:57:17 UTC) #2

bsalomon

11 years, 7 months ago (2013-02-07 21:22:42 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/7312061/diff/1/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.appspot.com/7312061/diff/1/src/gpu/GrContext.cpp#newcode37
src/gpu/GrContext.cpp:37: // debugging simpler.
On 2013/02/07 20:57:17, robertphillips wrote:
> maybe:
> "gpu.deferDrawing"
> "Defers rendering in GrContext via InOrderDrawBuffer"?

Done.

Expand All Messages | Collapse All Messages