Issue 7312057: Enhance GL error checking for non-Ganesh GL calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7312057: Enhance GL error checking for non-Ganesh GL calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by robertphillips

Modified:
11 years, 4 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

These changes would've flagged the multi-gpu-timer issue earlier in the development cycle. They also add an error abort from the infinite loop into which the bots were falling.

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -13 lines)			Patch
M	bench/BenchGpuTimer_gl.cpp	View	1 chunk	+8 lines, -1 line	0 comments	Download
M	bench/benchmain.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/tools.gyp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	include/gpu/gl/SkGLContext.h	View	1 chunk	+7 lines, -2 lines	0 comments	Download
M	src/gpu/gl/SkGLContext.cpp	View	2 chunks	+11 lines, -10 lines	0 comments	Download
M	tools/PictureRenderer.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

On 2013/02/07 19:11:34, robertphillips wrote: lgtm... at some point we should get rid of SK_GL* ...

11 years, 4 months ago (2013-02-07 19:29:36 UTC) #2

robertphillips

11 years, 4 months ago (2013-02-07 19:46:23 UTC) #3

Message was sent while issue was closed.

committed as 7647 & added SK_GL removal to TODO list

Expand All Messages | Collapse All Messages