Issue 7312056: Add a bench for SkBicubicImageFilter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7312056: Add a bench for SkBicubicImageFilter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by Stephen White

Modified:
11 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add a bench for SkBicubicImageFilter. Committed: https://code.google.com/p/skia/source/detail?r=7668

Patch Set 2 : Fixes re: comments #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -0 lines)			Patch
	A	bench/BicubicBench.cpp	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download
	M	gyp/bench.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + suggestions & questions https://codereview.appspot.com/7312056/diff/1/bench/BicubicBench.cpp File bench/BicubicBench.cpp (right): https://codereview.appspot.com/7312056/diff/1/bench/BicubicBench.cpp#newcode7 bench/BicubicBench.cpp:7: fix? https://codereview.appspot.com/7312056/diff/1/bench/BicubicBench.cpp#newcode16 bench/BicubicBench.cpp:16: An ...

11 years, 9 months ago (2013-02-07 16:48:38 UTC) #2

Stephen White

11 years, 9 months ago (2013-02-07 21:40:17 UTC) #3

https://codereview.appspot.com/7312056/diff/1/bench/BicubicBench.cpp
File bench/BicubicBench.cpp (right):

https://codereview.appspot.com/7312056/diff/1/bench/BicubicBench.cpp#newcode7
bench/BicubicBench.cpp:7: 
On 2013/02/07 16:48:38, robertphillips wrote:
> fix?

Done.

https://codereview.appspot.com/7312056/diff/1/bench/BicubicBench.cpp#newcode16
bench/BicubicBench.cpp:16: 
On 2013/02/07 16:48:38, robertphillips wrote:
> An interesting comment here?

Done.

https://codereview.appspot.com/7312056/diff/1/bench/BicubicBench.cpp#newcode23
bench/BicubicBench.cpp:23: :  INHERITED(param),
fScale(SkSize::Make(SkFloatToScalar(x), SkFloatToScalar(y))) {
On 2013/02/07 16:48:38, robertphillips wrote:
> overlength line?

Fixed.

https://codereview.appspot.com/7312056/diff/1/bench/BicubicBench.cpp#newcode41
bench/BicubicBench.cpp:41: paint.setImageFilter(bicubic);
On 2013/02/07 16:48:38, robertphillips wrote:
> No SkBENCHLOOP?

No; the raster path is pretty slow right now, even in Release, and I didn't want
to extend bot cycle times any more than necessary.  Maybe once I've optimized it
a bit, we could add an SkBENCHLOOP.

Expand All Messages | Collapse All Messages