Issue 7311059: Temporary patch to BenchPictures gpu timing problem

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7311059: Temporary patch to BenchPictures gpu timing problem (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by robertphillips

Modified:
11 years, 7 months ago

Reviewers:
EricB, bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

So .. calling BeginQuery twice in a row to start up two gpu timers causes bad things to happen. This patch just addresses the symptom (i.e., the bench bots getting stuck in an infinite loop) but a more thorough fix is required.

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	tools/PictureBenchmark.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/PictureBenchmark.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

robertphillips

11 years, 7 months ago (2013-02-07 16:21:54 UTC) #2

Message was sent while issue was closed.

Received verbal lgtm from Brian

committed as r7641

Expand All Messages | Collapse All Messages