Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 7310050: gm self-tests: generate JSON expectations, in addition to image expectations (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by epoger
Modified:
11 years, 7 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com, EricB
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

gm self-tests: generate JSON expectations, in addition to image expectations Committed: https://code.google.com/p/skia/source/detail?r=7624

Patch Set 1 #

Total comments: 1

Patch Set 2 : add_images_to_output_paths #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -120 lines) Patch
M + gm/tests/outputs/compared-against-different-pixels-images/output-expected/command_line View 1 1 chunk +1 line, -1 line 1 comment Download
M + gm/tests/outputs/compared-against-different-pixels-images/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels/output-expected/command_line View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-different-pixels/output-expected/json-summary.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D gm/tests/outputs/compared-against-different-pixels/output-expected/return_value View 1 1 chunk +0 lines, -1 line 0 comments Download
M gm/tests/outputs/compared-against-different-pixels/output-expected/stdout View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-empty-dir/output-expected/stdout View 1 chunk +3 lines, -3 lines 0 comments Download
M + gm/tests/outputs/compared-against-identical-bytes-images/output-expected/command_line View 1 1 chunk +1 line, -1 line 0 comments Download
M + gm/tests/outputs/compared-against-identical-bytes-images/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes/output-expected/command_line View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-identical-bytes/output-expected/json-summary.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-bytes/output-expected/return_value View 1 1 chunk +0 lines, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-bytes/output-expected/stdout View 1 1 chunk +0 lines, -3 lines 0 comments Download
M + gm/tests/outputs/compared-against-identical-pixels-images/output-expected/command_line View 1 1 chunk +1 line, -1 line 0 comments Download
M + gm/tests/outputs/compared-against-identical-pixels-images/output-expected/stdout View 1 1 chunk +1 line, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels/output-expected/command_line View 1 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels/output-expected/json-summary.txt View 1 1 chunk +0 lines, -25 lines 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels/output-expected/return_value View 1 1 chunk +0 lines, -1 line 0 comments Download
M gm/tests/outputs/compared-against-identical-pixels/output-expected/stdout View 1 1 chunk +0 lines, -3 lines 0 comments Download
M gm/tests/run.sh View 1 3 chunks +33 lines, -20 lines 1 comment Download

Messages

Total messages: 3
epoger
This CL doesn't actually test against the JSON expectations yet (gm doesn't know how to ...
11 years, 7 months ago (2013-02-06 17:11:15 UTC) #1
epoger
Ravi- patchset 2 incorporates your in-person suggestions (notes below). PTAL https://codereview.appspot.com/7310050/diff/4001/gm/tests/outputs/compared-against-different-pixels-images/output-expected/command_line File gm/tests/outputs/compared-against-different-pixels-images/output-expected/command_line (right): https://codereview.appspot.com/7310050/diff/4001/gm/tests/outputs/compared-against-different-pixels-images/output-expected/command_line#newcode1 ...
11 years, 7 months ago (2013-02-06 18:26:10 UTC) #2
rmistry
11 years, 7 months ago (2013-02-06 18:36:48 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b