Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2304)

Issue 7309060: Remove compile time option to use different types for text vertices. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by bsalomon
Modified:
11 years, 2 months ago
Reviewers:
JimVV
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Remove compile time option to use different types for text vertices. Committed: https://code.google.com/p/skia/source/detail?r=7658

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -250 lines) Patch
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrConfig.h View 2 chunks +0 lines, -19 lines 0 comments Download
M include/gpu/GrTextContext.h View 2 chunks +1 line, -3 lines 0 comments Download
M include/gpu/GrUserConfig.h View 1 chunk +0 lines, -7 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 7 chunks +11 lines, -31 lines 2 comments Download
D src/gpu/GrGpuVertex.h View 1 chunk +0 lines, -96 lines 0 comments Download
M src/gpu/GrTextContext.cpp View 5 chunks +12 lines, -35 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 7 chunks +9 lines, -48 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3
bsalomon
We used to think that there it's a perf win on some ES devices to ...
11 years, 2 months ago (2013-02-07 21:29:42 UTC) #1
JimVV
https://codereview.appspot.com/7309060/diff/1/src/gpu/GrDrawState.cpp File src/gpu/GrDrawState.cpp (right): https://codereview.appspot.com/7309060/diff/1/src/gpu/GrDrawState.cpp#newcode219 src/gpu/GrDrawState.cpp:219: int offset = kVec2Size; Should this be kVec2Size * ...
11 years, 2 months ago (2013-02-07 21:49:59 UTC) #2
bsalomon
11 years, 2 months ago (2013-02-13 20:37:39 UTC) #3
Message was sent while issue was closed.
(forgot to hit publish before checking this in)

https://codereview.appspot.com/7309060/diff/1/src/gpu/GrDrawState.cpp
File src/gpu/GrDrawState.cpp (right):

https://codereview.appspot.com/7309060/diff/1/src/gpu/GrDrawState.cpp#newcode219
src/gpu/GrDrawState.cpp:219: int offset =  kVec2Size;
On 2013/02/07 21:49:59, JimVV wrote:
> Should this be kVec2Size * (num_tex_coords(vertexLayout) + 1)?

Yup, nice catch.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b