lgtm On Thu, Feb 7, 2013 at 4:11 PM, <robertphillips@google.com> wrote: > Reviewers: bsalomon, > > Description: > Only the tests and bench apps seem to cause these asserts. > > Please review this at https://codereview.appspot.**com/7308064/<https://codereview.appspot.com/7308... > > Affected files: > M src/gpu/gl/SkGLContext.cpp > > > Index: src/gpu/gl/SkGLContext.cpp > ==============================**==============================**======= > --- src/gpu/gl/SkGLContext.cpp (revision 7653) > +++ src/gpu/gl/SkGLContext.cpp (working copy) > @@ -20,9 +20,10 @@ > SkGLContext::~SkGLContext() { > > if (fGL) { > - SK_GL(*this, DeleteFramebuffers(1, &fFBO)); > - SK_GL(*this, DeleteRenderbuffers(1, &fColorBufferID)); > - SK_GL(*this, DeleteRenderbuffers(1, &fDepthStencilBufferID)); > + // TODO: determine why DeleteFramebuffers is generating a GL > error in tests > + SK_GL_NOERRCHECK(*this, DeleteFramebuffers(1, &fFBO)); > + SK_GL_NOERRCHECK(*this, DeleteRenderbuffers(1, &fColorBufferID)); > + SK_GL_NOERRCHECK(*this, DeleteRenderbuffers(1, > &fDepthStencilBufferID)); > } > > SkSafeUnref(fGL); > > >
committed as r7657