Issue 7308047: Make windows GrGLCreateNatriveInterface not us GL.h and not use linker to resolve gl functions. Ins…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7308047: Make windows GrGLCreateNatriveInterface not us GL.h and not use linker to resolve gl functions. Ins… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bsalomon

Modified:
11 years, 9 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make windows GrGLCreateNatriveInterface not us GL.h and not use linker to resolve gl functions. Instead load the GL library and use GetProcAddress. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=7582

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+215 lines, -190 lines)			Patch
	M	src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp	View	1 2	3 chunks	+215 lines, -190 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

In the ANGLE build the linker may resolve to ANGLE's glGetString, etc rather than opengl32's.

11 years, 9 months ago (2013-02-05 16:02:51 UTC) #1

robertphillips

LGTM https://codereview.appspot.com/7308047/diff/4001/src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp File src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp (right): https://codereview.appspot.com/7308047/diff/4001/src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp#newcode13 src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp:13: #include <Windows.h> remove?

11 years, 9 months ago (2013-02-05 16:11:58 UTC) #2

bsalomon

11 years, 9 months ago (2013-02-05 16:14:01 UTC) #3

https://codereview.appspot.com/7308047/diff/4001/src/gpu/gl/win/GrGLCreateNat...
File src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp (right):

https://codereview.appspot.com/7308047/diff/4001/src/gpu/gl/win/GrGLCreateNat...
src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp:13: #include <Windows.h>
On 2013/02/05 16:11:58, robertphillips wrote:
> remove?

Done.

Expand All Messages | Collapse All Messages