Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(154)

Issue 7306103: Add C++ based faster masking library. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by tyoshino (chromium.org)
Modified:
12 years, 2 months ago
CC:
pywebsocket-reviews_googlegroups.com
Base URL:
http://pywebsocket.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add C++ based faster masking library. Making key related variables in util.py are renamed to less confusing names. Committed: 729

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -12 lines) Patch
A src/mod_pywebsocket/fast_masking.i View 1 2 3 4 5 1 chunk +99 lines, -0 lines 0 comments Download
M src/mod_pywebsocket/util.py View 2 chunks +27 lines, -11 lines 0 comments Download
M src/setup.py View 8 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 5
tyoshino (chromium.org)
Low priority
12 years, 3 months ago (2013-02-13 17:57:19 UTC) #1
Takashi Toyoshima
Sorry, can you share this review with ricea?
12 years, 3 months ago (2013-02-22 06:47:15 UTC) #2
tyoshino (chromium.org)
On 2013/02/22 06:47:15, Takashi Toyoshima wrote: > Sorry, can you share this review with ricea? ...
12 years, 3 months ago (2013-02-22 08:10:11 UTC) #3
Adam Rice
lgtm
12 years, 3 months ago (2013-02-25 10:29:21 UTC) #4
tyoshino (chromium.org)
12 years, 2 months ago (2013-03-05 05:25:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #9 manually as r729 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b