Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1059)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
7306097
: Use SkMWRandom in GLPrograms test. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 9 months ago by
bsalomon
Modified:
11 years, 9 months ago
Reviewers:
JimVV
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.
More Reviews
Description
Use SkMWRandom in GLPrograms test. R=jvanverth@google.com Committed: https://code.google.com/p/skia/source/detail?r=7721
Patch Set 1
#
Created:
11 years, 9 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+33 lines, -46 lines
)
Patch
M
include/gpu/GrEffectUnitTest.h
View
4 chunks
+6 lines, -6 lines
0 comments
Download
M
src/effects/SkBicubicImageFilter.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/SkColorMatrixFilter.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/SkDisplacementMapEffect.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/SkLightingImageFilter.cpp
View
3 chunks
+4 lines, -4 lines
0 comments
Download
M
src/effects/SkMagnifierImageFilter.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/SkMatrixConvolutionImageFilter.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/SkMorphologyImageFilter.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/SkTableColorFilter.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/gradients/SkGradientShader.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/gradients/SkGradientShaderPriv.h
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/gradients/SkLinearGradient.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/gradients/SkRadialGradient.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/gradients/SkSweepGradient.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/gradients/SkTwoPointConicalGradient.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/effects/gradients/SkTwoPointRadialGradient.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/gpu/GrEffect.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/gpu/effects/GrConfigConversionEffect.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/gpu/effects/GrConvolutionEffect.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/gpu/effects/GrSimpleTextureEffect.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
src/gpu/effects/GrTextureDomainEffect.cpp
View
1 chunk
+1 line, -1 line
0 comments
Download
M
tests/GLProgramsTest.cpp
View
2 chunks
+4 lines, -17 lines
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
bsalomon
11 years, 9 months ago (2013-02-12 21:56:46 UTC)
#1
Sign in
to reply to this message.
JimVV
On 2013/02/12 21:56:46, bsalomon wrote: LGTM
11 years, 9 months ago (2013-02-13 16:29:55 UTC)
#2
On 2013/02/12 21:56:46, bsalomon wrote: LGTM
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 7306097: Use SkMWRandom in GLPrograms test. (Closed)
Created 11 years, 9 months ago by bsalomon
Modified 11 years, 9 months ago
Reviewers: JimVV
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
