Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1642)

Issue 7305093: Fix failure to recover from GPU hang. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by apatrick1
Modified:
11 years, 2 months ago
Reviewers:
shannon.woods, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fix failure to recover from device hang. Sometimes IDirect3DDevice9Ex::CheckDeviceState returns S_PRESENT_MODE_CHANGED when the GPU has hung. It's not consistent, maybe one time out of two when I hang the GPU while running WebGL Aquarium. This unfortunately means that changes to display mode will cause ANGLE to report context lost. Other ideas appreciated. Committed: https://code.google.com/p/angleproject/source/detail?r=1829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/libEGL/Display.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4
apatrick1
Please take a look. Al
11 years, 2 months ago (2013-02-15 00:05:19 UTC) #1
apatrick1
I did some more testing. Apparently changing the display mode does _not_ cause CheckDeviceState to ...
11 years, 2 months ago (2013-02-15 20:28:01 UTC) #2
shannon.woods_transgaming.com
LGTM
11 years, 2 months ago (2013-02-19 22:58:31 UTC) #3
nicolas
11 years, 2 months ago (2013-02-19 23:47:57 UTC) #4
Message was sent while issue was closed.
It looks like this could occur when the driver thinks the display mode has
changed:
http://msdn.microsoft.com/en-us/library/windows/desktop/bb219624(v=vs.85).aspx I
guess a lost device could easily lose track of such parameters. According to
this MSDN page, Reset() should be called to stop returning this result code, so
we can indeed treat it the same as a lost device regardless of whether the
device is truly lost or it has fallen back to some emulation mode.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b