Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(678)

Issue 7305088: Fix moc generation with SK_SUPPORT_GPU defined (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by robertphillips
Modified:
11 years, 10 months ago
Reviewers:
EricB
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

moc now needs to see the SK_SUPPORT_GPU #define in order to correctly include/ignore the GLWidget

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gyp/debugger.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
robertphillips
11 years, 10 months ago (2013-02-13 20:06:20 UTC) #1
EricB
LGTM. Is this bug out of date: https://code.google.com/p/skia/issues/detail?id=862 ?
11 years, 10 months ago (2013-02-13 20:10:23 UTC) #2
robertphillips
Yes - I think we can just delete all the checked in moc files.
11 years, 10 months ago (2013-02-13 20:11:23 UTC) #3
robertphillips
11 years, 10 months ago (2013-02-13 20:12:37 UTC) #4
Message was sent while issue was closed.
committed as r7725
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b