Issue 7305086: Updated AdSense Management API samples to V1.2

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7305086: Updated AdSense Management API samples to V1.2 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by jalc

Modified:
12 years, 1 month ago

Reviewers:
jcgregorio_google

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 2 : Removed commented line #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -11 lines)			Patch
M	samples/adsense/generate_report.py	View	1	1 chunk	+20 lines, -10 lines	0 comments	Download
A	samples/adsense/get_all_saved_ad_styles.py	View		1 chunk	+63 lines, -0 lines	0 comments	Download
A	samples/adsense/get_all_saved_reports.py	View		1 chunk	+56 lines, -0 lines	0 comments	Download
M	samples/adsense/sample_utils.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jcgregorio_google

https://codereview.appspot.com/7305086/diff/1/samples/adsense/generate_report.py File samples/adsense/generate_report.py (right): https://codereview.appspot.com/7305086/diff/1/samples/adsense/generate_report.py#newcode35 samples/adsense/generate_report.py:35: #gflags.MarkFlagAsRequired('ad_client_id') Commented out line needs to either be uncommented ...

12 years, 5 months ago (2013-02-13 17:23:39 UTC) #1

jalc

Done! On 2013/02/13 17:23:39, jcgregorio_google wrote: > https://codereview.appspot.com/7305086/diff/1/samples/adsense/generate_report.py > File samples/adsense/generate_report.py (right): > > https://codereview.appspot.com/7305086/diff/1/samples/adsense/generate_report.py#newcode35 ...

12 years, 5 months ago (2013-02-13 17:32:05 UTC) #2

jcgregorio_google

LGTM On 2013/02/13 17:32:05, jalc wrote: > Done! > > On 2013/02/13 17:23:39, jcgregorio_google wrote: ...

12 years, 5 months ago (2013-02-13 19:22:02 UTC) #3

jcgregorio_google

12 years, 5 months ago (2013-02-13 20:36:02 UTC) #4

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=9cd9fe8624...

On 2013/02/13 19:22:02, jcgregorio_google wrote:
> LGTM
> 
> On 2013/02/13 17:32:05, jalc wrote:
> > Done!
> > 
> > On 2013/02/13 17:23:39, jcgregorio_google wrote:
> > >
> >
>
https://codereview.appspot.com/7305086/diff/1/samples/adsense/generate_report.py
> > > File samples/adsense/generate_report.py (right):
> > > 
> > >
> >
>
https://codereview.appspot.com/7305086/diff/1/samples/adsense/generate_report...
> > > samples/adsense/generate_report.py:35:
> > > #gflags.MarkFlagAsRequired('ad_client_id')
> > > Commented out line needs to either be uncommented out, or removed.

Expand All Messages | Collapse All Messages