Issue 7304055: Remove GR_STATIC_RECT_VB

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7304055: Remove GR_STATIC_RECT_VB (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bsalomon

Modified:
11 years, 9 months ago

Reviewers:
JimVV, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove GR_STATIC_RECT_VB Committed: https://code.google.com/p/skia/source/detail?r=7625

Patch Set 2 : #

Total comments: 1

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -117 lines)			Patch
M	include/gpu/GrConfig.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	include/gpu/GrUserConfig.h	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1	2 chunks	+1 line, -62 lines	0 comments	Download
M	src/gpu/GrGpu.h	View		1 chunk	+0 lines, -7 lines	1 comment	Download
M	src/gpu/GrGpu.cpp	View		1 chunk	+0 lines, -31 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

I found no test that run either faster or slower with this code path.

11 years, 9 months ago (2013-02-06 18:38:48 UTC) #1

JimVV

On 2013/02/06 18:38:48, bsalomon wrote: > I found no test that run either faster or ...

11 years, 9 months ago (2013-02-06 18:43:14 UTC) #2

robertphillips

lgtm + 1 suggestion https://codereview.appspot.com/7304055/diff/2001/src/gpu/GrGpu.h File src/gpu/GrGpu.h (right): https://codereview.appspot.com/7304055/diff/2001/src/gpu/GrGpu.h#newcode530 src/gpu/GrGpu.h:530: // these are mutable so ...

11 years, 9 months ago (2013-02-06 18:49:38 UTC) #3

bsalomon

11 years, 9 months ago (2013-02-06 18:49:55 UTC) #4

On 2013/02/06 18:49:38, robertphillips wrote:
> lgtm + 1 suggestion
> 
> https://codereview.appspot.com/7304055/diff/2001/src/gpu/GrGpu.h
> File src/gpu/GrGpu.h (right):
> 
> https://codereview.appspot.com/7304055/diff/2001/src/gpu/GrGpu.h#newcode530
> src/gpu/GrGpu.h:530: // these are mutable so they can be created on-demand
> remove fUnitSquareVertexBuffer too?

duh.. nice catch

Expand All Messages | Collapse All Messages