Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 7301099: expose the full token response in OAuth2Client and OAuth2Decorator

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by ryanb
Modified:
12 years, 4 months ago
Reviewers:
jcgregorio_google
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Description

expose the full token response in OAuth2Client and OAuth2Decorator

Patch Set 1 #

Total comments: 4

Patch Set 2 : incorporated review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M oauth2client/appengine.py View 1 7 chunks +20 lines, -0 lines 0 comments Download
M oauth2client/client.py View 6 chunks +10 lines, -3 lines 0 comments Download
M tests/test_oauth2client.py View 4 chunks +9 lines, -1 line 0 comments Download
M tests/test_oauth2client_appengine.py View 1 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 5
ryanb
joe and i discussed this here: https://plus.sandbox.google.com/106134299616714031548/posts/XtuGWPzG3Rc i still need to test it on my ...
12 years, 4 months ago (2013-02-14 23:05:16 UTC) #1
jcgregorio_google
https://codereview.appspot.com/7301099/diff/1/oauth2client/appengine.py File oauth2client/appengine.py (right): https://codereview.appspot.com/7301099/diff/1/oauth2client/appengine.py#newcode799 oauth2client/appengine.py:799: if decorator._token_response_param and credentials.token_response: Use discovery._add_query_parameter(). https://codereview.appspot.com/7301099/diff/1/tests/test_oauth2client_appengine.py File tests/test_oauth2client_appengine.py ...
12 years, 4 months ago (2013-02-20 19:49:46 UTC) #2
ryanb
thanks for the review! https://codereview.appspot.com/7301099/diff/1/oauth2client/appengine.py File oauth2client/appengine.py (right): https://codereview.appspot.com/7301099/diff/1/oauth2client/appengine.py#newcode799 oauth2client/appengine.py:799: if decorator._token_response_param and credentials.token_response: On ...
12 years, 4 months ago (2013-02-21 22:17:35 UTC) #3
ryanb
btw, i also tested manually and confirmed that this works with my application (https://github.com/snarfed/freedom).
12 years, 4 months ago (2013-02-21 22:22:15 UTC) #4
jcgregorio_google
12 years, 4 months ago (2013-02-22 21:24:00 UTC) #5
LGTM.

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=cf7dde6b55...

On 2013/02/21 22:22:15, ryanb wrote:
> btw, i also tested manually and confirmed that this works with my application
> (https://github.com/snarfed/freedom).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b