expose the full token response in OAuth2Client and OAuth2Decorator

expose the full token response in OAuth2Client and OAuth2Decorator

[ryanb, 2013-02-14 23:05:16]

joe and i discussed this here:
https://plus.sandbox.google.com/106134299616714031548/posts/XtuGWPzG3Rc

i still need to test it on my specific use case, but i think it will do what i
need. i'll report back soon.

thanks in advance!

[jcgregorio_google, 2013-02-20 19:49:46]

https://codereview.appspot.com/7301099/diff/1/oauth2client/appengine.py
File oauth2client/appengine.py (right):

https://codereview.appspot.com/7301099/diff/1/oauth2client/appengine.py#newco...
oauth2client/appengine.py:799: if decorator._token_response_param and
credentials.token_response:
Use discovery._add_query_parameter().

https://codereview.appspot.com/7301099/diff/1/tests/test_oauth2client_appengi...
File tests/test_oauth2client_appengine.py (right):

https://codereview.appspot.com/7301099/diff/1/tests/test_oauth2client_appengi...
tests/test_oauth2client_appengine.py:508: self.assertEqual(Http2Mock.content,
simplejson.loads(urllib.unquote(response)))
80 chars

[ryanb, 2013-02-21 22:17:35]

thanks for the review!

https://codereview.appspot.com/7301099/diff/1/oauth2client/appengine.py
File oauth2client/appengine.py (right):

https://codereview.appspot.com/7301099/diff/1/oauth2client/appengine.py#newco...
oauth2client/appengine.py:799: if decorator._token_response_param and
credentials.token_response:
On 2013/02/20 19:49:46, jcgregorio_google wrote:
> Use discovery._add_query_parameter().

ah, much nicer, thanks. done.

https://codereview.appspot.com/7301099/diff/1/tests/test_oauth2client_appengi...
File tests/test_oauth2client_appengine.py (right):

https://codereview.appspot.com/7301099/diff/1/tests/test_oauth2client_appengi...
tests/test_oauth2client_appengine.py:508: self.assertEqual(Http2Mock.content,
simplejson.loads(urllib.unquote(response)))
On 2013/02/20 19:49:46, jcgregorio_google wrote:
> 80 chars

Done.

[ryanb, 2013-02-21 22:22:15]

btw, i also tested manually and confirmed that this works with my application
(https://github.com/snarfed/freedom).

[jcgregorio_google, 2013-02-22 21:24:00]

LGTM.

Committed in
https://code.google.com/p/google-api-python-client/source/detail?r=cf7dde6b55...

On 2013/02/21 22:22:15, ryanb wrote:
> btw, i also tested manually and confirmed that this works with my application
> (https://github.com/snarfed/freedom).