Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(511)

Issue 7301093: Updating GCE PHP Getting Started sample to v1beta14

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by jbsimon
Modified:
12 years, 11 months ago
Reviewers:
kbrisbin
Visibility:
Public.

Description

Updating GCE PHP Getting Started sample to v1beta14

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removal of Developer Key setting and updates to README instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
M README.md View 1 2 chunks +7 lines, -6 lines 0 comments Download
M app.php View 1 13 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 5
jbsimon
12 years, 11 months ago (2013-02-13 22:53:55 UTC) #1
kbrisbin
The app.php file looks good, aside from the one comment. I have some suggestions for ...
12 years, 11 months ago (2013-02-15 22:48:43 UTC) #2
jbsimon
12 years, 11 months ago (2013-02-16 00:47:43 UTC) #3
jbsimon
On 2013/02/16 00:47:43, jbsimon wrote: - Removed the code to set Developer Key in app.php ...
12 years, 11 months ago (2013-02-16 00:50:26 UTC) #4
kbrisbin
12 years, 11 months ago (2013-02-16 01:21:10 UTC) #5
LGTM!

I totally missed the project key in the README, but in any case, I think it's
good to remove it since it's not necessary.

Thanks!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b