Issue 7300091: Making tileGrid and Rtree consider clipped bounds.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7300091: Making tileGrid and Rtree consider clipped bounds.

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by junov1

Modified:
12 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Making tileGrid and Rtree consider clipped bounds. Currently SkBBoxRecord::transformBounds verifies the bbox against the current clip, but stores the unclipped bounds. This CL fixes that, which improves query result quality and also reduces recording overhead.

Patch Set 1 #

Patch Set 2 : #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -20 lines)			Patch
M	src/core/SkBBoxHierarchyRecord.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBBoxHierarchyRecord.cpp	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/core/SkBBoxRecord.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBBoxRecord.cpp	View	1	4 chunks	+25 lines, -14 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

junov1

12 years, 11 months ago (2013-02-12 15:41:49 UTC) #2

New patch. Complete re-write to processes the clip and bbox in device space
coordinates. This eliminates the overhead of calling getClipBounds instead of
getClipDeviceBounds.
Leads to picture record time improvement of more than 10% on ~20% of skp files.

Expand All Messages | Collapse All Messages