Issue 7300089: Move blend optimization functions to GrDrawState.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7300089: Move blend optimization functions to GrDrawState. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bsalomon

Modified:
11 years, 7 months ago

Reviewers:
JimVV

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Move blend optimization functions to GrDrawState. Committed: https://code.google.com/p/skia/source/detail?r=7703

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+209 lines, -230 lines)			Patch
M	src/gpu/GrDrawState.h	View	1 2	2 chunks	+56 lines, -0 lines	0 comments	Download
M	src/gpu/GrDrawState.cpp	View		1 chunk	+128 lines, -0 lines	0 comments	Download
M	src/gpu/GrDrawTarget.h	View		3 chunks	+5 lines, -67 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View		1 chunk	+7 lines, -151 lines	0 comments	Download
M	src/gpu/gl/GrGpuGL_program.cpp	View		5 chunks	+13 lines, -12 lines	0 comments	Download

Total messages: 2

bsalomon

These functions were on GrDrawTarget simply because it had access to the vertex layout.

11 years, 7 months ago (2013-02-11 19:53:20 UTC) #1

JimVV

11 years, 7 months ago (2013-02-11 20:34:23 UTC) #2

On 2013/02/11 19:53:20, bsalomon wrote:
> These functions were on GrDrawTarget simply because it had access to the
vertex
> layout.

LGTM.